re: The Ultimate Answer To The Very Common Angular Question: subscribe() vs | async Pipe VIEW POST

TOP OF THREAD FULL DISCUSSION
re: Would i need to manually unsubscribe in OnDestroy if I did it this way (not @Effect) as you have described?

Yes, whenever you do explicit .subscribe() call, you are automatically responsible to call .unsubscribe(). Even better would be to use .pipe(takeUntil(onDestroy$)) which is declarative ;)

awesome, thanks!

so then I would also need to do this, right?

ngOnDestroy() {
    this.onDestroy$.next(true);
    this.onDestroy$.unsubscribe();
  }
ngOnInit() {
   this.source$.pipe(takeUntil(onDestroy$)).subscribe()
}

ngOnDestroy() {
    this.onDestroy$.next(true);
    this.onDestroy$.complete()
}

CHeers!

code of conduct - report abuse