DEV Community

Discussion on: 8 Tips on Giving Effective Code Reviews

Collapse
 
thealiilman profile image
Ali Ilman

Thanks for the feedback, German. 🙂

The first type of code review can be done by anyone, indeed. Having linters help too!

Regarding adequateness, I feel there are two ways to review this. Design discussion and code review. I try to hold design discussions if the feature / fix being worked on is major and / or extensive. Changing the approach before you write the code is more efficient than changing the approach after going through a code review.

Collapse
 
heroincommunity profile image
German Chyzhov

Indeed, absolutely agree that it is better to review approach before implementing it.