I'm a software engineer working as a full-stack developer using JavaScript, Node.js, and React. I write about my experiences in tech, tutorials, and share helpful hints.
The review period is so that maintainers have a chance to review pull requests and mark any with an invalid tag for any that seem like they are made just to get +1 pull requests.
I'm a software engineer working as a full-stack developer using JavaScript, Node.js, and React. I write about my experiences in tech, tutorials, and share helpful hints.
Thanks Ryan. But what is a review period? It says that my other four has 1 day left? Hope you can help! ;)
The review period is so that maintainers have a chance to review pull requests and mark any with an invalid tag for any that seem like they are made just to get +1 pull requests.
Thanks Ryan. ;) That makes more sense.
@ryansmith , what happens if the PR is not reviewed by the maintainer, or the PR is not marked with an invalid tag at all?
@sudo_kaizen In that case, it counts towards Hacktoberfest contributions after the review period.
ok.. that means, according to the hacktoberfest rules, merging a PR is not necessary only passing the review period is necessary.