DEV Community

Discussion on: Ruby Getters and Setters

Collapse
 
tadman profile image
Scott Tadman

It seems odd to declare these as private since you can always refer to them by their @ name internally.

Collapse
 
phallstrom profile image
Philip Hallstrom

It can be odd, but it can also be useful as it allows you to more easily override it later without having to go find/replace all instances of @year in your class.

Or, if a class inherits from it and needs to change how year is generated it's easier it doesn't have to worry about parent class using @year.

If that makes sense.

Thread Thread
 
tadman profile image
Scott Tadman

It just seems inconsistent to use year and self.year = ... in the code where one's bare and the other's necessarily prefixed, instead of @year consistently. This plus the way that @year is by default "private".

One of the major goals of object-oriented design is to properly contain any changes like that, so replacing @year with something else is at least contained to the one file or scope.

Subclass concerns are valid, though in Ruby it's generally understood you need to play nice with your parent's properties and avoid really getting in there and wrecking around.