DEV Community

Discussion on: Advantages of Git-flow over standard git commands

Collapse
 
stereoplegic profile image
Mike Bybee • Edited

That's on the stakeholder, and you need to set a deadline for their feedback. If feedback is still absent at the deadline, and the PR passes tests, (dev team) review, and definition of done, you push the release without them. If you never got the feedback required to complete, you make a decision on what to do with it (keep the branch alive while rebasing, save a diff, or just kill it, and close the issue as stale due to no feedback).

The key in either case is to document your attempts to get feedback and the stakeholder's failure to provide it (CYA).

Collapse
 
dhandspikerwade profile image
Devin Handspiker-Wade

Maybe it's because I am viewing this as an agency, but none of that seems possible.

The definition of done requires the client's approval as something cannot be released to a client's site/app/service without their approval. Going back to a client with "The change needs to be re-tested " when they finally provide their feedback is a good way to end up with unhappy clients.

Thread Thread
 
stereoplegic profile image
Mike Bybee

I wasn't speaking specifically to clients (many stakeholders are internal, and I've worked numerous projects where all of them were), but even with external clients, you need language in the contract for cases where they are not responsive.

And sure, it is often the case that the feature just doesn't get pushed (but the client is still billed for your time) if they fail fulfill their obligation as a stakeholder.

And again, CYA applies universally.