Reviewing Pull Requests
Part of the 0.3 release was reviewing pull requests for the select Seneca applications that we are all working on together.
The pull request that I reviewed had to do with adding a prettier configuration.
The pull request included the .vscode files and an empty .prettierrc file. I wrote a comment explaining the difference between changing the settings within the editor and changing the settings through a configuration file for every contributor to be able to use in the future.
Also I recently reviewed a second PR, just correcting a very small grammar mistake to test out git hub's comment functionality on PRs:
What I learned
That occasionally I might have something to offer in terms of commentary/guidance and to constantly be checking the PR tab because the conversations only last so long as those PRs are open, if you wait around you can't partake.
Oldest comments (0)