DEV Community

loading...

Discussion on: The Inspiration API: A project built with Scala & Play Framework

Collapse
samukce profile image
Samuel P.

Hey Daniel thanks for sharing. I would like to suggest one thing in your improvement list. It's good practice to have the responsibility well divided (looks for S.O.L.I.D.). So, you could separate your database repository logic from your controller. What do you think?

Collapse
dan_mcm_ profile image
Daniel McMahon Author

Many thanks for the feedback Samuel. There is definitely an opportunity to improve the logic here, the reasoning I had it all contained together was purely convenience as my main goal was to try get the API working initially. I'll definitely look into improving upon the logic there!