Thank you for this brilliant initiative, that I'd have love to see a few months ago when I wanted to get to know PRs and OSS contribution workflows.
I have a few suggestions that are a bit off the main objective (add mode words via PRs), but if you want / need me to open an issue for that, I'd be happy to do so.
As the primary objective (I assume) is to keep the code as simple as possible to simplify contributions, you may want to sort words by alphabetical order. I assume it would allow start a conversation between maintainer and contributor if a new PRs is correct (adding a word) but may be improved by adding the said word at the right index.
It would also avoid word repetition more easily (e.g. «shallow» is listed twice; don't know if it's intentional for further contribution suggestions or not).
This is only a suggestion. You may think that it would probably confuse beginners more than current codebase state. It's up to you, really; just thought this suggestion may help in a way or another.
Thanks again for this great idea an approach :)
(of course externalizing words to a file or db may be an even «cleaner» approach; but I guess would not meet the «beginner friendly codebase» objective as its current state)
I'd really really appreciate if you open an issue for that😁.
It would also avoid word repetition more easily (e.g. «shallow» is listed twice; don't know if it's intentional for further contribution suggestions or not).
That's just my mistake. Thanks for pointing it out 😆!!
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Hi!
Thank you for this brilliant initiative, that I'd have love to see a few months ago when I wanted to get to know PRs and OSS contribution workflows.
I have a few suggestions that are a bit off the main objective (add mode words via PRs), but if you want / need me to open an issue for that, I'd be happy to do so.
As the primary objective (I assume) is to keep the code as simple as possible to simplify contributions, you may want to sort words by alphabetical order. I assume it would allow start a conversation between maintainer and contributor if a new PRs is correct (adding a word) but may be improved by adding the said word at the right index.
It would also avoid word repetition more easily (e.g. «shallow» is listed twice; don't know if it's intentional for further contribution suggestions or not).
This is only a suggestion. You may think that it would probably confuse beginners more than current codebase state. It's up to you, really; just thought this suggestion may help in a way or another.
Thanks again for this great idea an approach :)
(of course externalizing words to a file or db may be an even «cleaner» approach; but I guess would not meet the «beginner friendly codebase» objective as its current state)
That is a brilliant idea!!
I'd really really appreciate if you open an issue for that😁.
That's just my mistake. Thanks for pointing it out 😆!!