DEV Community

Discussion on: How to go fast

Collapse
 
quii profile image
Chris James

I think code reviews are great! Having them as a weekly thing with the whole team to talk about technical issues is lovely.

I dont think it's necessary to check the work of 2 developers who have worked on a task.

Collapse
 
exadra37 profile image
Paulo Renato • Edited

Sorry but I completely disagree here... a merge request with the code review are necessary for each task, otherwise technical debt will grow out of control easily, because you will not get back to it later as you told yourself you would... you know the business always have a huge backlog waiting for you, and once you tell them that the task is done, is done, no time to go back to make SOLID and Clean Code.

Thread Thread
 
quii profile image
Chris James • Edited

Technical debt will occur whether you do pull requests or not. It's unlikely you will get code perfect the first time no matter how many people check it because the correct abstraction today is the wrong one tomorrow.

I will fix technical debt as I see it and in order for teams to go fast the business has to trust the technical team.

And as the post implies, in order to go fast you don't have a huge backlog waiting for you. You have short term goals that you iterate on over time and the team is empowered to make whatever technical choices they need to keep moving fast.

Thread Thread
 
gypsydave5 profile image
David Wickes

If you're in conflict with 'the business', if they're refusing to rely on your expertise, if you can't work collaboratively with 'them', if you're not in control of your own working methods and backlog... you've got bigger problems than can be fixed with code review and pull request fetishism.