Just a query, you said the above code will run Prettier and ESLint rules against all js,jsx,ts,tsx files in the src directory OR will it run for all the specified files in src which are STAGED?
How can we make it run for only staged files. I am stuck with this in my project because the eslint takes too much time as it runs on all files in the directory.
Thanks for the post Yash, it was very helpful. Just wanted to point out that I don't think this is necessary. Correct me if I'm wrong, but from the lint-staged documentation and from what I see from my own project after setting this up, linting runs for only the files which are staged and also match the specified glob pattern.
I used this setting and it only throws lint errors for staged changes while I commit even though there are other unstaged files with lint errors.
I think the line to note is
"eslint src/*.js --fix-dry-run" which you've mentioned.
I've used "eslint --ext .js,.jsx --fix-dry-run" without specifying a target, so that it doesn't run for all files in the src directory, only the staged files that are fed into this command by lint-staged.
Just a query, you said the above code will run Prettier and ESLint rules against all js,jsx,ts,tsx files in the src directory OR will it run for all the specified files in src which are STAGED?
It will run for all the js,jsx,ts,tsx files in the src directory whether they are staged or not.
How can we make it run for only staged files. I am stuck with this in my project because the eslint takes too much time as it runs on all files in the directory.
Try replacing your "lint" command in package.json with below command and if that works then you can do something similar for prettier too.
"lint": "eslint src/**/**/*.js --fix-dry-run git diff --diff-filter=d --cached --name-only | grep -E './**/*.(js|jsx|ts|tsx|css|scss|md)$'"
Thanks for the post Yash, it was very helpful. Just wanted to point out that I don't think this is necessary. Correct me if I'm wrong, but from the lint-staged documentation and from what I see from my own project after setting this up, linting runs for only the files which are staged and also match the specified glob pattern.
"husky": {
"hooks": {
"pre-commit": "lint-staged"
}
},
"lint-staged": {
"*.{js,jsx,ts,tsx}": [
"npx prettier --write",
"eslint --ext .js,.jsx --fix-dry-run"
]
}
I used this setting and it only throws lint errors for staged changes while I commit even though there are other unstaged files with lint errors.
I think the line to note is
"eslint src/*.js --fix-dry-run" which you've mentioned.
I've used "eslint --ext .js,.jsx --fix-dry-run" without specifying a target, so that it doesn't run for all files in the src directory, only the staged files that are fed into this command by lint-staged.
Updated for 2021 with all the fixes