DEV Community


Thank You for Your Code Review

ninjapanzer profile image Paul Scarrone ・2 min read

In July 2018, I joined the PhalconPHP documentation team. It has been an amazing experience and I wanted to give you some of my insights from my first month as an internal contributor of a FOSS(Free Open Source Software) project. I have always contributed to FOSS from the outside but hadn't found a project that really drew me in like Phalcon and Zephir did. I have tried a lot of things to balance out my work-week burnout and keep me excited about software development. FOSS is my catharsis that reminds me why I got involved in computers in the first place.

Saying "Thank You"

I spend most of my time in the world of private (Closed Source) development we use a common term for a successful code review, "πŸ‘ LGTM". It's matter of fact and there is no confusion about its meaning, "Looks Good To Me". But in my time with a FOSS team, I see something else. "LGTM" is replaced with "Thank You". The currency in FOSS is passion instead of money. It's a small way to reward someone's passion that is so simple I don't know why we don't do it all the time. Well, I have adopted this for my daily work now its, "LGTM, Thank You".

Whats wrong with "πŸ‘ LGTM"?

Inherently nothing, but if we break it down what we are really saying is I approve but this is only my opinion and I don't posit my approval is an empirical truth of the safety of this code. There is nothing wrong with saying, "I have read this and see nothing wrong." It's a very honest statement and very defensible in the event that there is in fact something wrong with the code under review. So in that sense, it is a little meaningless. Why not just use, πŸ‘ Thank You? Simply put we approve and appreciate your work. We can take an overall meaningless sentiment and convert it to something possibly empowers other developers to build a deeper emotional bond with their work. In an industry that honors workaholics why not try to inspire passion at the office the same way, FOSS teams do at home.

Discussion (0)

Editor guide