Received this amazing pull request to my app, and was able to guide the contributor to finally getting it merged. Not really my win per-se, but it sure felt like one :)
Harsh Shandilya
@msf_jarvis
This is an example of a VERY good pull request. The author's documented the new code, explained his entire reasoning in the pull request body, tested on a variety of configurations, and offered suggestions on what further can be done with this.
Received this amazing pull request to my app, and was able to guide the contributor to finally getting it merged. Not really my win per-se, but it sure felt like one :)