DEV Community

loading...

Discussion on: I made over 1,000 code reviews - this is what I learned

Collapse
mjuraj profile image
Juraj Malenica Author

Ideally, the feature would be small enough to make for a reasonable PR. Breaking up the PR would split the context - it's hard to see the big picture.

For example, let's say that you're developing a web app and you are adding comments section. Maybe it would make sense to split the PR into backend and frontend, especially if those two are reviewed by different people.

Collapse
slawikus profile image
Slawa Gladkov

Thanks for reply! Sure, feature slicing is always a good idea but I am talking about situations when feature cannot be further sliced down.

Thread Thread
mjuraj profile image
Juraj Malenica Author

Yeah, then it's better to have it as one PR. What helps me the most then is to sit with the author and speak my thoughts out loud. It makes the process go faster