DEV Community

Discussion on: Finished My Portfolio Site

Collapse
mattdevio profile image
Matt G

Looks good! It's a clean design and content is easy to find. If I was you, I would limit the infinite horizontal scaling; it looks weird on large displays. Also the social icons look a little cramped. Other then that, GREAT!

Collapse
bbarbour profile image
Brian Barbour Author

Can you elaborate on the scaling thing?

Collapse
mattdevio profile image
Matt G

I think the page needs a wrapper. Where the max width is like 1200px. Right now, the page continues to scale as you expand the viewport.

Thread Thread
bbarbour profile image
Brian Barbour Author • Edited on

That's so weird because there is a wrapper set to 100vw.

EDIT: It was my animation on the image. After I turned that off its fine and doesn't move the viewport.