DEV Community

Discussion on: What's your typical process for reviewing a pull request in GitHub?

Collapse
 
mateusaugusto profile image
Mateus Oliveira

0 Should pass in the test (all) to open a pull request
1 Pull the code. For me is not easy to understand the changes on a pull request
2 I can reviewing in different ways it depends if is a senior or a junior developer if is a junior the reviewing process is in pair.
3 Look through duplication code, performance and the most important details
4 Reviewing process is not a feature/bug test remind the developer of this