I know how to fix it @reobin
. I will create an issue and put a PR up for it. We need to explicitly call unmountComponentAtNode in an InstantClick.on('change', () => {}) event. This is something that normally we wouldn't have to do, but because we use InstantClick, it's necessary. It also explains why I saw components repeated in the Preact dev tools.
I need to do it for pretty much all out components that get mounted via render. e.g.
Accessibility First DevRel. I focus on ensuring content created, events held and company assets are as accessible as possible, for as many people as possible.
There is currently a bug that caused the the shortcuts to compound. It's actually a side effect of this issue
Preact Components not unmounting due to InstantClick page lifecycle events. #11458
Describe the bug
I know how to fix it @reobin . I will create an issue and put a PR up for it. We need to explicitly call
unmountComponentAtNode
in anInstantClick.on('change', () => {})
event. This is something that normally we wouldn't have to do, but because we use InstantClick, it's necessary. It also explains why I saw components repeated in the Preact dev tools.I need to do it for pretty much all out components that get mounted via
render
. e.g.To Reproduce
You will not see this behaviour as it's something under the hood. It manifests itself in an issue like #11371
Expected behavior
Preact components should be unmounted when an InstantClick even changes the page.
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
I wrote an article asking how we can get better discoverability the other day but as of yet there is not a list of shortcuts.
Just press
/
should take you to the search, I thinkshift + /
is still calling/
functions though, I'd like?
to open a list of shortcuts one day 😅forem.dev/link2twenty/keyboard-sho...
You know I should really look through all the bugs in the repo shouldn’t I lol!
Saying that it is way more fun having you “swat me down” on things that are already known 🤣🤣😜
?
no longer initiates search. That's one step closer