While asynchronous methods are being moved to separate Active Jobs (#1996, #2497), we keep _without_delay methods for a while, because the jobs that use this method can still exist at the moment of deploy.
But eventually, we need to delete them to declutter because most of them are not actively used in the codebase.
Some of these methods are used in the codebase explicitly. I suppose that it's worth to replace such calls with the perform_now job calls. But at least we should delete the unused methods.
</div>
<div class="gh-btn-container"><a class="gh-btn" href="https://github.com/thepracticaldev/dev.to/issues/2950">View on GitHub</a></div>
I would like to see published_at date of an episode on its page, in the podcasts feed and on the podcast's episodes list.
It would allow me to understand if the episode is fresh and if the podcast is active.
</div>
<div class="gh-btn-container"><a class="gh-btn" href="https://github.com/thepracticaldev/dev.to/issues/3498">View on GitHub</a></div>
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
A couple of issues from me to contribute to:
Few items left to move
delays to ActiveJob:As described in #2497, to be less dependent of
DelayedJobwe also need to move jobs which are created by callingdelaymethod toActiveJob:Here is the list of the calls:
Slackbot.pingMembershipMailer.delay.new_membership_subscription_emailMembershipMailer.delay.subscription_update_confirm_emailMembershipMailer.delay.subscription_cancellation_emailuser.followreaction.createArticleAnalyticsFetcher.new.update_analyticsHtmlVariantSuccess.createHtmlVariantTrial.createmessage.send_pushRssReader.new.fetch_usertrigger_delayed_indexActions for each of the calls:
ActiveJob, specify a queue namedelaymethod calls with a jobperform_latercallperform_enqueued_jobinstead ofrun_background_jobs_immediatelyhelperRemember to pass record
ids (if needed) instead of ActiveRecord objects to a job to avoid deserialization errors (#1621)Remove unused methods:
While asynchronous methods are being moved to separate Active Jobs (#1996, #2497), we keep
_without_delaymethods for a while, because the jobs that use this method can still exist at the moment of deploy. But eventually, we need to delete them to declutter because most of them are not actively used in the codebase. Some of these methods are used in the codebase explicitly. I suppose that it's worth to replace such calls with theperform_nowjob calls. But at least we should delete the unused methods.I would like to see
published_atdate of an episode on its page, in the podcasts feed and on the podcast's episodes list. It would allow me to understand if the episode is fresh and if the podcast is active.