In the worst case, it will traverse the DOM from the clicked element to the html tag for every click and get the attribute in question, which modern browsers can easily do within a few milliseconds even for an html structure that is over 200 nodes deep.
At the same time, you'll save memory for the listeners when you can do it with one of them - and, as I said, it is a good solution to DOM changes that introduce new dialog elements. Also, you can run it even before dom.ready, which adds even more flexibility.
dialog elements are a great addition and I'm glad they're getting implemented, but a key part of their functionality relies on JavaScript: to open a <dialog> you need to use JavaScript to set the open attribute.
It'd be great if there was a way to make a <a> or a <button> elements capable of opening dialogs.
Precident already exists for page interactivity baked into HTML - for example <a href="#.."> can already scroll the page, and <details> elements are capable of hiding elements behind interactivity, so I think it stands to reason <dialog> elements could be opened by other page elements.
It's a small trade-off, as far as I'm concerned.
In the worst case, it will traverse the DOM from the clicked element to the html tag for every click and get the attribute in question, which modern browsers can easily do within a few milliseconds even for an html structure that is over 200 nodes deep.
At the same time, you'll save memory for the listeners when you can do it with one of them - and, as I said, it is a good solution to DOM changes that introduce new dialog elements. Also, you can run it even before
dom.ready, which adds even more flexibility.There is an issue on the spec's GitHub, no idea if it will go anywhere but may as well have a look.
dialog elements are a great addition and I'm glad they're getting implemented, but a key part of their functionality relies on JavaScript: to open a
<dialog>you need to use JavaScript to set theopenattribute.It'd be great if there was a way to make a
<a>or a<button>elements capable of opening dialogs.Precident already exists for page interactivity baked into HTML - for example
<a href="#..">can already scroll the page, and<details>elements are capable of hiding elements behind interactivity, so I think it stands to reason<dialog>elements could be opened by other page elements.I have added a comment to your proposal.
I saw that 😀
Worth noting HTML is not case sensitive so the
opensModalattribute would have to beopens-modal