DEV Community

Discussion on: 3 Popular Website Heroes Created With CSS Grid Layout

Collapse
 
kisanbhat profile image
Kisan Bhat

Stephanie,
Very informative article.
I was working step by step on Marketing Call-to-Action (CTA) and Image.
When I added the header code

header {
  // ...existing styles
  min-height: 65vh;
  max-height: 600px;
}
img {
  object-fit: cover;
  object-position: 5vw -5vmin;
  height: 100%;
  width: 60%;
}

The image in Firefox did not take the height of the header. What I am doing wrong here? I even checked the codepen in FF the header image still took the full height instead of max-height of 600px.

Collapse
 
5t3ph profile image
Stephanie Eckles

Looks like there is a mismatch in the behavior between Firefox and Chrome - changing min-height to just height resolves it ๐Ÿ‘ Thanks for commenting, I'll update the article!

Collapse
 
kisanbhat profile image
Kisan Bhat

Thanks, the issue resolved.