DEV Community

Discussion on: We created the Crystal language, ask us anything!

Collapse
 
jwoertink profile image
Jeremy Woertink

In the PullRequests for the repo, there's a lot of PRs that have passed the travis build, and been reviewed and accepted. Is there anyone that goes through all of these PRs to either merge them, or reject them? Someone to do housekeeping on the PRs?

Collapse
 
matiasgarciaisaia profile image
Matías García Isaía

We try and review&merge the PRs whenever we can, but we have to decide between investing our energies on that versus developing other features or tasks for the project.

We love having all those PRs and community engagement, but it's our responsibility to prevent lots of little steps in the form of PRs from diverting the path we want the project to pursue.

So there are PRs hanging there because we didn't find time to merge them, but also because we want to have a more general view of the underlaying issues, and come up with a global solution to that - instead of adding a bunch of patches for special cases.

There's a great talk called Hammock Driven Development, by Clojure's Rich Hickey that explains this concept way better than me.

Collapse
 
matiasgarciaisaia profile image
Matías García Isaía

Re-reading the whole thing, if there's a PR with green CI + two core members' approvals, it should be merged. So, if you happen to find one that isn't - please ping us, because it's a mistake :)

Thread Thread
 
jwoertink profile image
Jeremy Woertink

Ok, that makes sense. I'll keep an eye out for any of those. Maybe that will help clean up some PRs.