DEV Community

Discussion on: What's your typical process for reviewing a pull request in GitHub?

Collapse
 
jmervine profile image
Joshua Mervine • Edited

Love this list!

A comment on the first point...

I don’t always stop if the tests aren’t passing , especially when reviewing less senior level engineers PRs. I’ve found that in a collaborative environment, a detailed review in spite of test failures often shows an obvious mistake that can quickly be pointed out, increasing the overall velocity of the initiative.

One possible addition...

Reviewing the test additions or updates first can often guide the review nicely, framing the changes in an easy to follow and logical way. Plus, if reviewing someone for the first time, it helps clarify the patterns and structures they use.

Collapse
 
ben profile image
Ben Halpern

Awesome