Yes, it would definitely be safer if TDD was followed but I was hoping there would be a general way to answer the question: Is the sum of two approved PRs also an approved PR?
The answer is probably some function of tests, thoroughness of review process and a few other factors (perhaps). Thoughts?
Like much of what we do, there isn't a single right answer here. It depends on your confidence in your code and your tests.
My general answer would be no - PR-1 + PR-2 =/> PR-1 * PR-2 (sum meaning both approved, multiplication meaning one merged into the other). But, that does not mean that under certain conditions (which I believe were met in your case), it can't be assumed.
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Yes, it would definitely be safer if TDD was followed but I was hoping there would be a general way to answer the question: Is the sum of two approved PRs also an approved PR?
The answer is probably some function of tests, thoroughness of review process and a few other factors (perhaps). Thoughts?
Like much of what we do, there isn't a single right answer here. It depends on your confidence in your code and your tests.
My general answer would be no -
PR-1 + PR-2 =/> PR-1 * PR-2(sum meaning both approved, multiplication meaning one merged into the other).But, that does not mean that under certain conditions (which I believe were met in your case), it can't be assumed.