DEV Community

Discussion on: Optimal pull request size

Collapse
 
jhuebel profile image
Jason Huebel

Pointing to your last comment about "someone with other priorities", this seems to be the case with the project I'm contributing to. It hasn't had any development activity for a couple of years.

Truthfully, if the original author never merges my PR it won't bother me at all. But I felt obligated (regardless of the permissive MIT license) to contribute back to a project whose code I was basing my changes on.

If it turns out that the original author isn't very responsive, I'll probably just keep moving along with my fork since the changes I'm making are beneficial to the company I work for.

Thread Thread
 
bosepchuk profile image
Blaine Osepchuk

That sounds like a very reasonable approach.

Cheers, Jason.