DEV Community

Discussion on: Your code has lots of security and performance issues, he said...

Collapse
 
jbeetz profile image
J Beetz

Hi Slavius,

At the risk of seeming confrontational (i'm trying not to be). I'm curious to understand your reasoning to discount the concerns raised in points 2 & 3.

Short passwords with little to no complexity are useless.
check this link to see how quickly a short password can be guessed.

Allowing continued login attempts simply ties up resources and allows the attacker to eventually guess their way in. So, at the least your service will run slower than it should and at the worst the attacker can eventually get in. Rate limiting logins can go along way to securing resources by deterring brute force and rainbow dictionary attacks.

Of course context is key for this type of concern. Is the API accessible via public ip address? If not, it's probably ok to not worry so much about rate limiting, but password complexity is a must regardless (in my opinion).

As for Item 1, I too have thought that HTTPS alone is not enough to secure certain types of data in transit. Although the profession at large doesn't comment on it, i wonder if there's something to that question. This SO Question seems to negate the concern.

I'm looking forward to reading your findings in future posts.
Respectfully,

Collapse
 
slavius profile image
Slavius

Hi,

thanks for your feedback. We'll get to the password part soon when I finish my next post. ;) Spoiler alerts - it was a misunderstanding what the password length check in that context means and what is it used for.

Stay tuned!