DEV Community

loading...

Discussion on: How to do a better code review?

Collapse
gombosg profile image
Gergely Gombos

Here is my experience.

A good approach is not requesting, only suggesting changes, and pointing out actual requests i.e. where the current situation is not acceptable. Always tell why so that the PR creator can work out a solution.

Also, it's important to know what is (your) preference/opinion vs. an actual issue with a code (bug, not clean enough etc.).

And most importantly, don't commit into the code unless you want to drive people nuts. :D

I think that if you're unsure then ask instead of stating things, and suggest instead of requesting. Assertive communication goes a long way, and every PR submitter needs to get used to getting their code reviewed.

Collapse
paharihacker profile image
Rajesh Dhiman Author

Thanks a lot Gergely

Forem Open with the Forem app