Native Android developer/Consultant for Appwise, I work on custom projects for clients.
PHP/JS (web) developer in my freetime. Trying to keep learning in an ever changing tech world.
Add support for Github pull request via liquid tags in markdown.
{% github https://github.com/thepracticaldev/dev.to/pull/1633 %}
My first time setting up a Ruby environment and actually developing in Ruby, so let me know if I should have done things differently.
I also fixed a couple of pre-commit errors, strange that the thrown errors where from parts that I didn't edit. So I assume that a lot of people skip the pre-commit check with --no-verify.
Anyways the only error I couldn't fix was this section because it would parse the html instead of showing it in the codeblock:
github.com/thepracticaldev/dev.to/...
Related Tickets & Documents
Closes #1760
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[x] help tab in the markdown editor
[ ] docs.dev.to
[ ] readme
[ ] no documentation needed
[optional] What gif best describes this PR or how it makes you feel?
I think people are skipping the pre-commit hook, check my comment in my PR and in my last post:
What type of PR is this? (check all applicable)
Description
Add support for Github pull request via liquid tags in markdown.
{% github https://github.com/thepracticaldev/dev.to/pull/1633 %}My first time setting up a Ruby environment and actually developing in Ruby, so let me know if I should have done things differently.
I also fixed a couple of pre-commit errors, strange that the thrown errors where from parts that I didn't edit. So I assume that a lot of people skip the pre-commit check with
--no-verify. Anyways the only error I couldn't fix was this section because it would parse the html instead of showing it in the codeblock: github.com/thepracticaldev/dev.to/...Related Tickets & Documents
Closes #1760
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?
Changelog: Github PR Liquid Tag Support
Glenn Carremans