DEV Community

DEV Community is a community of 577,245 amazing developers

We're a place where coders share, stay up-to-date and grow their careers.

Create new account Log in
loading...

Discussion on: Angular: Setters vs ngOnChanges - which one is better?

View post Full discussion

Replies for: ngOnChanges({ name, email }: SimpleChanges) { const username = name.currentValue || email.currentValue; this.username$.next(username); } ...

Collapse
gc_psk profile image
Giancarlo Buomprisco Author •

Hi! do you mean that name or email could be undefined? TBH I'd never ship this to production - just needed a short example with multiple inputs 😅

Collapse
reibo_bo profile image
Bo Vandersteene •

Ok so if you have a component that uses your code like this

<my-component [email]="email$ | async" 
                               [username]="username$ | async"> </my-component>

If the input of the observables look like this

email$    = -E----
username$  =  ----U--

Then the ngOnChanges will be called first with only email and then with only username so one of the two is undefined. Only the values that are changed are submitted in the SimpleChanges