Those who don't bother to communicate or document their work.
I once had someone go into our codebase, change the setup and architecture of it, disable linting and remove existing documentation. The kind of huge PR with hundreds of files changed. PR title: "bugfix". Description: empty.
They didn't update the readme, didn't add any document their changes, didn't even tell anyone how to run the new code (because of course that had changed too). They approved their own PR and merged it in. Didn't tell anyone on Slack or Jira either. Was a great surprised that Monday morning.
At least it taught me what happens if you don't change your settings on GitHub and just trust people to ask for reviews 🤷♂️
// , “It is not so important to be serious as it is to be serious about the important things. The monkey wears an expression of seriousness... but the monkey is serious because he itches."(No/No)
Those who don't bother to communicate or document their work.
I once had someone go into our codebase, change the setup and architecture of it, disable linting and remove existing documentation. The kind of huge PR with hundreds of files changed. PR title: "bugfix". Description: empty.
They didn't update the readme, didn't add any document their changes, didn't even tell anyone how to run the new code (because of course that had changed too). They approved their own PR and merged it in. Didn't tell anyone on Slack or Jira either. Was a great surprised that Monday morning.
At least it taught me what happens if you don't change your settings on GitHub and just trust people to ask for reviews 🤷♂️
Aghh that sounds terrible! Yeah, lesson learned, gatekeeping is necessary in most cases. Always put a description in your PR, ALWAYS!
Pre. Receive. Hooks.