DEV Community

Cover image for Danger on Rails: make robots do some code review for you!

Danger on Rails: make robots do some code review for you!

Vladimir Dementyev on July 02, 2019

This article is a b-side of my recent RailsConf talk "Terraforming legacy Rails applications" (video, slides). We, developers, spend an essential ...
Read full post
Collapse
 
jsshanon profile image
Shanon JS •

Kinda of automatic code (or project) checker plugged into a tool to do automatic code (or project) checks ? That's awesome !

With my team, we just write Git pre-hook scripts, why you don't do that too ? There is no interest to push incomplete things on the server no ?

Collapse
 
palkan_tula profile image
Vladimir Dementyev •

Danger allows us to add code review specific checks, for example:

  • PRs guidelines (labels, merge commits)
  • Highlight critical changes (e.g, updated dependencies, credentials)—we want to make sure reviewers are aware of these changes and won't miss them
  • Run non-critical, warning-only checks.

We use hooks heavily in development (and even built our own hook manager—Lefthook), mostly for running linters and tests, i.e. something that is required to pass. We do not use Danger for that (although it's possible), we use it as a code review little helper, not guard)