DEV Community

Discussion on: Benevolent code review

Collapse
dylanwatsonsoftware profile image
Dylan Watson • Edited on

Thanks! I really enjoyed reading this. Whilst I'm not sure I agree with the idea of not changing your code to make it easier to test (since in my experience it often makes the code simpler to understand as well) but I feel this might be your point. Ultimately, it's the developer (the one with the most context for the change) to make the decision. As reviewers, we should try harder to make it clear why we are requesting changes (and give that extra context) and that what we say is often only suggestions and discussion starters.

Anyway it definitely made me think! 👏👏