DEV Community

Discussion on: Javascript Algorithms #1: Counting the Vowels in a String Of Text

Collapse
 
dimkl profile image
Dimitris Klouvas

It may be a correct algorithm but the implementation is not a very good one. The countVowelsRecursive should be a pure function and not depend to scoped count variable. What happens when we run the countVowelsRecursive twice in the same code snippet? Is the result of the 1st call the same as the 2nd?

Collapse
 
boianivanov profile image
Boian Ivanov

No worries, you can make it a function in a function with the parent one having the count = 0 and then the child one doing the iteration. Though you got the point that the idea behind it was to showcase different algorithms, right ?

Thread Thread
 
dimkl profile image
Dimitris Klouvas

Yeah, i mentioned that the algorithm is correct at the beginning. But i felt the urge to comment about the implementation because i think it matters. Nevermind, the topic is about the algorithm so let's move on.