DEV Community

loading...

Discussion on: How to Create Configurations for Different Environments in Your Node Applications

Collapse
dgreene profile image
Dan Greene

don't ever code db parameters (INCLUDING PASSWORD) in a file that's in source control.... -1 point.

Collapse
jrdev_ profile image
Jr. Dev 👨🏾‍💻 Author

I'm guessing you missed the bold text at the bottom.

Dont ever comment on an article critiquing it without first reading the full contents... -1 point

Collapse
dgreene profile image
Dan Greene

Fair enough, but why even use that as an example, if you immediately say "don't do this"? You could have picked API url endpoints, or other non-secure environment specific configuration values to use as an example.

That said, I fully concede my skimming the last paragraph, and accept my -1.

Thread Thread
jrdev_ profile image
Jr. Dev 👨🏾‍💻 Author

😂 you gracefully accepted that -1, well played 👏

I'm not saying not to do it, the configurations in the example could be fully legit, I'm just saying don't add it to source control.