Discussion on: Head First Design Pattern: 4 of 10

View post

For Selenium in Java I was using a singleton pattern to setup the WebDriver instance. Since switching to Kotlin, I was having issues with it working reliably with the object way. I was getting multiple browsers opened, which is contrary to the singleton pattern purpose.

How are you using this pattern with or without the object concept in Android?

Cihat Gündüz • Jul 19 '21

Could it be that your code was getting called multiple times or in multiple threads? I'm not sure but I can imagine that with Selenium. You might want to search for "thread-safe singleton" in Kotlin when trying to fix it again, quite possible the object approach isn't by default, but I'm sure there's an easy fix.

Andy Delso • Jul 19 '21

Ah that is a good point to make. It is possible I set it up with parallel running without thinking about it! Will do and thanks for the tip!

Oluwasanmi Aderibigbe • Jul 19 '21

That makes a lot of sense. Thanks Cihat for the explanation. Although, kotlin object is actually thread safe. kotlinlang.org/docs/object-declara...

Andy Delso • Jul 21 '21

That is what I thought, but if it is spinning up multiple threads, maybe that is why it is spinning up multiple browser instances. I’ll have to look into it again when I get time away from Android studies lol.

Oluwasanmi Aderibigbe • Jul 6 '21 • Edited

Oh, That's very weird. I don't know anything about Selenium. I've always used the object keyword whenever I need to use the Singleton pattern but you can try this. It should work.

fun main() {
    val signleton = ManualSignleton.getInstance()
}

class ManualSignleton {
    private constructor()

    companion object {
        @Volatile
        private var INSTANCE: ManualSignleton? = null

        fun getInstance(): ManualSignleton {
            return INSTANCE ?: synchronized(this) {
                val newInstance = ManualSignleton()
                INSTANCE = newInstance
                newInstance
            }
        }
    }
}

Let me know if it does

Andy Delso • Jul 9 '21

If and when I get back to the project, I can try it! Thanks!