DEV Community

Discussion on: Let's make my website even better

Collapse
 
davidszabo97 profile image
Dávid Szabó
  1. What's your reason to use CSS Grid? The layout looks pretty simple.
  2. On every navigation I can see the font change. That's really annoying.
  3. Colors are killing my eyes. Gray on white is difficult to read. You really should reconsider that gray. You are using that everywhere. (dequeuniversity.com/rules/axe/2.2/...)
  4. Your CSS is 250KB, why?
  5. You might inline your footer and header logo to save requests. But that's optional in HTTP/2 world.
Collapse
 
starbist profile image
Silvestar Bistrović • Edited

Thank you for the awesome feedback.

  1. CSS Grid is very well supported. It should be used for layout, as I am doing here.
  2. That texhnique is called FOFT.
  3. I am considering changing this.
  4. Inline fonts.
  5. Great find, I will consider fixing this.
Collapse
 
starbist profile image
Silvestar Bistrović

I fixed the font loading issues.

Collapse
 
davidszabo97 profile image
Dávid Szabó
  1. That's a good reason :D
  2. Well, I just learned a new thing. Can you cache the font?
  3. Are you inlining fonts and loading them externally too? See image below I think it's a huge waste of bandwidth. I am downloading 433 KB, 289 KB of that is just fonts and css. (gzipped) Can you get away from these fonts and use the web safe fonts? Or get rid of the inline fonts atleast.
Thread Thread
 
starbist profile image
Silvestar Bistrović

It seems something is not working with font caching. I will notify you when I fix this.

Thread Thread
 
dayvidwhy profile image
David Young

For fonts I'd suggest linking through from google fonts, don't inline them, and lazy load them like this meowni.ca/posts/web-fonts/

Thread Thread
 
starbist profile image
Silvestar Bistrović • Edited

After reading this article, that dates from 2016, I decided to stick with the current font loading technique since it is recommended by Zach.

Learn more about ih here: zachleat.com/web/comprehensive-web...