DEV Community

Discussion on: Developer/designer?

Collapse
 
davids89 profile image
David

I think you first need to sketch your app. As you say that you are learning, I guess you need to become a good developer before learn design seriously. The refactor <div> you mentioned will be fixed with time when you can able to build better apps. Don't push it, learning is hard at first.

Collapse
 
javascriptcoff1 profile image
JavaScript➕Coffee🚀

I know it is a learning curve. I just need to try and not get frustrated if what I've sent as a PR doesn't get approved first (or even second) time round. Luckily my mentor is incredibly patient haha!

Collapse
 
mastacheata profile image
Mastacheata

I'm working as a software developer for well over 10 years now and about 4 of that in Teams with review structure in place:

The quota of my Code that goes through review without any comments is probably somewhere around 10%. For me it's mostly fails in Content-Review that annoy me personally. Code-Review is fine, I even learn a few things every now and then when colleagues point out easier or more elegant ways to solve stuff.

Collapse
 
davids89 profile image
David

Fine, but rarely a PR is approved at first time :D