Knowledge transference. Developers are smart people, smart people want to know more, reviews are a way to spread that knowledge around.
At my last position we had a team agreement that no PR will sit for more than 24 hours without being viewed and no more than 48 hours (not counting weekends) without an approve/decline.
Myself, I would do PR's after lunch and at the end of the day. At this temp reviews would last no more than 15 minutes and would not be pressured.
I'm a Software Engineer based in Dublin. I love crafting software and experimenting with languages and technologies. I'm a #DevOps advocate and continuous improvement pursuer.
I think the 24-48 hours agreement is pretty reasonable.
15 minutes review is a great achievement and hopefully it leads people to open short and manageable PRs.
I totally agree, team agreement is vital here.
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Knowledge transference. Developers are smart people, smart people want to know more, reviews are a way to spread that knowledge around.
At my last position we had a team agreement that no PR will sit for more than 24 hours without being viewed and no more than 48 hours (not counting weekends) without an approve/decline.
Myself, I would do PR's after lunch and at the end of the day. At this temp reviews would last no more than 15 minutes and would not be pressured.
YMMV, the important part is the team agreement.
I think the 24-48 hours agreement is pretty reasonable.
15 minutes review is a great achievement and hopefully it leads people to open short and manageable PRs.
I totally agree, team agreement is vital here.