DEV Community

Discussion on: Writing Clean Code

View post

Replies for: Nice Article, I think that example can be shorter (avoiding unnecessary declarations and/or sentences) also is mixing snake case with camel case a...

Collapse
 
dallgoot profile image
dallgoot • • Edited

because i don't trust frameworks blindly:

function can_view(string $scope, int $owner_id) : bool {
    $user = Auth::user();
    if(!$user || !method_exists($user, "hasRole") || !property_exists($user, "id")){
        throw "Error : Current User state is undetermined"
    }

    return $scope === 'public' || $user->id === $owner_id || $user->hasRole('admin');
}

taking advantages of boolean shortcuts : assuming that the owner of content is always allowed to view whatever $scope it is