Positive feedback does benefit the code and the developer. If you see a pattern or refactor that makes the code better pointing it out to the dev helps highlight it.
As you have pointed out code reviews can be really rough emotionally for devs both new and experienced and the positive comments really help negate that.
That being said great article! I like the point about running the tests as part of the review.
Lead at iO Academy in Bath. Passionate about all things web, especially front-end. Striving for constant self improvement and helping those around me do the same.
I certainly would not discourage highlighting good solutions to reinforce good practise, however it is fairly common for code review comments to be mostly constructive. While I would not discourage positive feedback, I was using the point to lead onto how to foster a positive environment without developing an envronment where your developers expect constant positive praise in a code review, as that is just not productive.
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Positive feedback does benefit the code and the developer. If you see a pattern or refactor that makes the code better pointing it out to the dev helps highlight it.
As you have pointed out code reviews can be really rough emotionally for devs both new and experienced and the positive comments really help negate that.
That being said great article! I like the point about running the tests as part of the review.
I certainly would not discourage highlighting good solutions to reinforce good practise, however it is fairly common for code review comments to be mostly constructive. While I would not discourage positive feedback, I was using the point to lead onto how to foster a positive environment without developing an envronment where your developers expect constant positive praise in a code review, as that is just not productive.