DEV Community

Discussion on: What is the proper etiquette for declining PRs on open source projects you own?

Collapse
 
mortoray profile image
edA‑qa mort‑ora‑y

A key is to be honest. Don't reject a PR on artificial grounds, such as bad style, or missing tests, if you just don't like it. The submitted might correct the problems and submit again, thereby wasting a lot of time. If something doesn't fit with your vision then just say it directly, or perhaps ask them why they think it fits.

Feature requests are pretty easy to ignore. Just give it a priority, or tag, and move on. Nobody expects them to be done in a timely fashion.

Defects should be prioritized if you have the time. Base this on the quality of the issue report. A clear report, clear description/reproduction/etc. should be looked at sooner. Anything which doesn't seem clear can just be marked as needing details, then closed after a period of time.

In the end it's your project. Realistically you'll onyl have a tiny few good contributors. Cater to them since they'll be the most productive. don't waste time following up with people that are only partially interested, or unwilling to adapt to your style. Don't be a dick either, otherwise you'll chase everybody away.