DEV Community

Discussion on: What bothers you about a dev?

Collapse
caroso1222 profile image
Carlos Roso Author • Edited on

The one thing that really puts me off is when my PR reviewer force-push commits on my PRs without any feedback. Peer reviews are not supposed to be one-way only: open the PR, let the tech lead finish it. The loop must be closed and you should get appropriate comments and feedback so that you can go back and fix the PR yourself.

As a PR reviewer, always make sure to communicate your thinking and your suggestions. Do not just push code to "fix" the things your way. It a disservice in the long term: they didn't learn because you didn't teach.

Collapse
emma profile image
Emma Goto 🍙

This sounds so weird to me because I've worked at 3 separate companies and I've never seen this happen! Didn't think anyone even did it.

Collapse
caroso1222 profile image
Carlos Roso Author

Yeah it's the worst feeling ever :(