DEV Community

Discussion on: What do you look for in a PR review?

Collapse
 
caelinsutch profile image
caelinsutch

Readability
I don't really care how many one liners you have, if they're not readable, they aren't useful. Inline comments, correctly named variables, and DRY code is my number one thing.

Lint it please
I'm a little OCD about this, but I hate when other programmers don't lint their code :( Makes me really annoyed.

Top Level Documentation
Each file should have some JSdoc quality explanations of the file, I should be able to quickly read through a summary to see what each method and class does.

Collapse
 
caroso1222 profile image
Carlos Roso

All in for ripping off one-liners here too!