Hi Ali,

I have a few comments, hope it helps:

1. Prefer initialization to assignment. Keywords: assignment vs initialization

// bad practice 
int first;
first=34;

// good practice
int first = 34;

1. Prefer cmath::abs to writing your own absolute number function. Related question:

   What is different about C++ math.h abs() compared to my abs()

   May 20 '10 Comments: 7 Answers: 8

   

   17

   

   I am currently writing some glsl like vector math classes in C++, and I just implemented an abs() function like this:

   template<class T>
   static inline T abs(T _a)
   {
       return _a < 0 ? -_a : _a;
   }
   

   I compared its speed to the default C++ abs from math.h like…

   Open Full Question

2. Use floating numbers for division, unless you intentionally want to lose the decimal part.

3. It is a good idea to write functions and call these functions from main. I understand that you are writing simple programs but writing functions prepares you for the more complex stuff you will face later on.

Don't lose your motivation and try to learn new things everyday. Have a good one!