DEV Community

Discussion on: I use the GitHub Desktop app for one thing. Am I doing this wrong?

Collapse
 
ben profile image
Ben Halpern

Cool. I have hub installed, I guess I just never used it this way. I'm curious whether the mental overhead of remembering the number and switching applications like that will be the right solution. I do quite like clicking a button, but I'll examine this as an approach.

Now that I'm thinking about it, this might be something I could do entirely in VSCode.

I just installed this, and I will give it a try:

Microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code

Review and manage your GitHub pull requests directly in VS Code

This extension allows you to review and manage GitHub pull requests in Visual Studio Code. The support includes:

  • Authenticating and connecting VS Code to GitHub.
  • Listing and browsing PRs from within VS Code.
  • Reviewing PRs from within VS Code with in-editor commenting.
  • Validating PRs from within VS Code with easy checkouts.
  • Terminal integration that enables UI and CLIs to co-exist.

Demo

Getting Started

It's easy to get started with GitHub Pull Requests for Visual Studio Code. Simply follow these steps to get started.

  1. Make sure you have VSCode version 1.27.0 or higher.
  2. Download the extension from the marketplace.
  3. Reload VS Code after the installation (click the reload button next to the extension).
  4. Open your desired GitHub repository.
  5. Go to the SCM Viewlet, and you should see the GitHub Pull Requests treeview. On the first load, it will appear collapsed…
Collapse
 
bnb profile image
Tierney Cyren

This is what I was going to suggest. I absolutely love this extension for this use case. One of my awesome-* repos used to have merge conflicts with basically every PR because of how I initially structured it (an OSS contributor came and restructured it to make this not happen anymore 💖) and this extension saved so much time when I started using it.

Collapse
 
daveskull81 profile image
dAVE Inden

That VS Code plugin could likely do what you need. If it does and that is all you use the Github desktop app for I would say replace it. But, if you like working the other way I would say stick with it. It’s hard to argue with the fact that it works and you get your desired results. I don’t think you should consider your approach “wrong” or “inappropriate” because just like most things with development there is multiple ways to get work done and that’s okay.

Collapse
 
apjanke profile image
Andrew Janke

I use hub for this too, all the time. You can also just copy and paste the URL to the GitHub PR page and use that instead of the issue number in the hub checkout <whatever> command line.