DEV Community

Discussion on: How to make good code reviews and win colleagues?

Collapse
 
asynccrazy profile image
Sumant H Natkar

I think empathy is an important factor when doing any code review, because it is not necessary that the person before you thinks in the same way as you do while solving a problem.

Another factor is experience, as your experience increases, so does the way how you write the code, so that factor should also be considered.

My code review once was done by a principal architect, and although all his points were valid, he completely did in a negative way cross questioning and showing everything which I did was wrong, this impacts a developer's confidence in a big way.

Collapse
 
samizan profile image
Samer Azani

True. In some cases, people forget that they are dealing with another human, and they comment as if they are thinking out loud. Sometimes this happens involuntarily, like in times of a deadline day, which is Okay I guess. But having this attitude consistent on a regular bases is an indicator of poor dev team culture.