DEV Community

Discussion on: A Simple Weather Web App

Collapse
 
aminnairi profile image
Info Comment hidden by post author - thread only visible in this permalink
Amin

Well done! Careful mate when exposing your credentials since they can be abused by malicious persons. Nothing fancy, but worse that can happen is your account getting blocked or banned. Just a friendly reminder for client app security.

Collapse
 
arwazkhan189 profile image
Arwaz Khan

Thanks, I will take care of that.

Collapse
 
mateuszjansowa profile image
Info Comment hidden by post author - thread only visible in this permalink
Mateusz Sowa

You should at least hide your API key. I suggest using another .js module for that and .gitignore not to upload it.
Why do you declare variables using both ES5 and ES6 syntax? :) If you know ES6 it is better to stick with it :)
Apart from that nice design! Your app looks really decent :)

Some comments have been hidden by the post's author - find out more