😀 you caught me, in "challenges" I also want to draw attention to my project, but I really expect that someone will take part and I will be able to help the person with my advice (or I'll learn from him myself 😉). Initially, I wanted to do challenges separately from what I do myself, but it took too much time, so I decided to combine these two directions into one
There is really no reason why I ignore section, I just rarely use it and then I forgot about it again, in the next release I'll fix it, great note! I also agree about div.main, now I opened the code and looked at the page and I understand that it looks strange, a more correct solution would be to make .installation part of the header, and get rid of div.main completely, I also wrote it down as a necessary fix 👍
body: min-width: 320px; I use because I see no reason to adapt the layout, at such a width. I'm not sure that there are real devices on which the user will surf the web with a smaller screen width (and if they do, the markup may still have problems due to long titles or something similar)
No, I split CSS files and use @import only for convenience during development, the ready-made bundle includes all the styles in one file. If I understand your question correctly 🙂
I was very happy to read your message and comments on the code (with your example, you showed how the code review works, it was cool), it gave me new strength, thank you very much 😊
http://perpetual.education is a design/programming school. We like to be part of the discussion over here at Dev.to / We have time-slots for free conversations for career advice IRL : )
Yeah. You are pro. I've never been able to read such great code - and then as questions - and then have the person actually receive it well. You are AWESOME. I (in this case @sheriffderek c/o PE) will do the challenges for sure. But I'll do all 3 together. Who knows when the 'watch' will support websites... but we just leave the width as fluid as possible... what if there is a phone with 310px? With the @import / I like to teach with it - but haven't checked in on it in a while... maybe soon http 2 will deal with it better? But for now we use a preproecessor. Thanks for being cool! - but now / side question... do we really need modals?
http://perpetual.education is a design/programming school. We like to be part of the discussion over here at Dev.to / We have time-slots for free conversations for career advice IRL : )
Regarding the width, yes, you are right, but in this case, the content can be scrolled 🙂 here I also took into account the specifics of the site and since this is documentation, I think the main users are users with a large screen, so I decided to save a little time and do this restriction
Modals are a tool that marketers actively use, and I think our goal as developers is to make this interface element as convenient as possible, but if your interface can do without it, that's great, you will definitely take some unnecessary load off the users 😄
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
😀 you caught me, in "challenges" I also want to draw attention to my project, but I really expect that someone will take part and I will be able to help the person with my advice (or I'll learn from him myself 😉). Initially, I wanted to do challenges separately from what I do myself, but it took too much time, so I decided to combine these two directions into one
There is really no reason why I ignore
section, I just rarely use it and then I forgot about it again, in the next release I'll fix it, great note! I also agree aboutdiv.main, now I opened the code and looked at the page and I understand that it looks strange, a more correct solution would be to make.installationpart of theheader, and get rid ofdiv.maincompletely, I also wrote it down as a necessary fix 👍body: min-width: 320px;I use because I see no reason to adapt the layout, at such a width. I'm not sure that there are real devices on which the user will surf the web with a smaller screen width (and if they do, the markup may still have problems due to long titles or something similar)No, I split CSS files and use
@importonly for convenience during development, the ready-made bundle includes all the styles in one file. If I understand your question correctly 🙂I was very happy to read your message and comments on the code (with your example, you showed how the code review works, it was cool), it gave me new strength, thank you very much 😊
Yeah. You are pro. I've never been able to read such great code - and then as questions - and then have the person actually receive it well. You are AWESOME. I (in this case
@sheriffderekc/o PE) will do the challenges for sure. But I'll do all 3 together. Who knows when the 'watch' will support websites... but we just leave the width as fluid as possible... what if there is a phone with 310px? With the @import / I like to teach with it - but haven't checked in on it in a while... maybe soon http 2 will deal with it better? But for now we use a preproecessor. Thanks for being cool! - but now / side question... do we really need modals?Also - you should join the CSS Discord: we need people who can write HTML and CSS well! discord.gg/pFc6XmH
Regarding the width, yes, you are right, but in this case, the content can be scrolled 🙂 here I also took into account the specifics of the site and since this is documentation, I think the main users are users with a large screen, so I decided to save a little time and do this restriction
Modals are a tool that marketers actively use, and I think our goal as developers is to make this interface element as convenient as possible, but if your interface can do without it, that's great, you will definitely take some unnecessary load off the users 😄