DEV Community

Merge GitHub Pull Requests without leaving command line

Kay Gosho on February 20, 2019

My previous workflow in my personal project was like this: git checkout -b awesome-feature Edit file git add .; git commit -m 'created awesome fe...
Collapse
 
vbjay profile image
Jay Asbury

You do realize that if you do the merge locally and push the commits to the GitHub remote, the pull request will say merged?

Collapse
 
acro5piano profile image
Kay Gosho

Yeah... I forgot the feature! Haha

git checkout master
git merge awesome-feature
git push origin master

is enough! Thanks.

Collapse
 
chrisbaltazar profile image
Christian Baltazar

Hi Jay, I'm having an issue on that note actually, I did the following on my side:
git checkout feature
git checkout master
git merge --squash feature
git commit -m "Merged feature by squash"
git push origin master
git push --delete feature

But the original PR created still says OPEN, not merged... could this be because I also deleted the related branch?? I was expecting to be as easy as you said...

Collapse
 
emjayoh profile image
Matt Ogram

yeah or just merge the branch locally.. heh.

Collapse
 
pauguillamon profile image
PauGuillamon

Interesting tool! But if you're working alone and no one is going to review the code, then why not avoid the PR process and merge/commit directly into the main branch?

Collapse
 
acro5piano profile image
Kay Gosho

Always pushing to master is okay, but I want to log my work explicitly.
And if I develop my own OSS, lots of pull request is good for the project insights, as it looks development is active.

Collapse
 
pauguillamon profile image
PauGuillamon

What do you mean by log your work explicitly? You can still create your feature branches and merge them to master. Or am I missing something?
IMHO development will still look active if you update your project regularly, without needing to do PRs if you're the only developer.

Thread Thread
 
acro5piano profile image
Kay Gosho

What do you mean by log your work explicitly?

I mean, people can follow code changes by looking at PRs of the repository.

Yes, as you said we don't have to create each PRs if I'm the only developer.
However, I sometimes want to do self-review on GitHub.