DEV Community

Discussion on: Angular: Setters vs ngOnChanges - which one is better?

 
abelardoit profile image
abelardoit

And what's the solution to avoid this situation, please? Would you opt by adding a setter to the property?

Thread Thread
 
bo profile image
Bo Vandersteene

It depends what do you want to achieve with this function.
Like I read this it should only take the email into account if the name is empty so something like this:

 ngOnChanges({ name, email }: SimpleChanges) {
    const username = name?.currentValue ?? this.name ?? email?currentValue ?? this.email
    this.username$.next(username);
  }
Enter fullscreen mode Exit fullscreen mode
Thread Thread
 
abelardoit profile image
abelardoit

Thanks for replying asap! Best regards.