I agree. I always found it daunting looking at a PR with 40+ files changed without even knowing what the PR should be doing. In the end, it always seemed to just end up being more efficient sitting down with the owner of the PR and them walking through what changed and reviewing it with them.
Oh and also actually getting the person to RUN the code to see it actually is doing what they expect it to do rather than assuming its working correctly.
Code review should include reviewing the history, it is such an important log, those in person conversations need written down for the poor maintenance folks when both of you aren't available.
I agree. I always found it daunting looking at a PR with 40+ files changed without even knowing what the PR should be doing. In the end, it always seemed to just end up being more efficient sitting down with the owner of the PR and them walking through what changed and reviewing it with them.
Oh and also actually getting the person to RUN the code to see it actually is doing what they expect it to do rather than assuming its working correctly.
Plug
Git is a Communication tool
Jesse Phillips ・ Dec 12 '18 ・ 2 min read
Or a little more specific
Partnered Code Reviews
Jesse Phillips ・ Feb 13 '19 ・ 1 min read
Code review should include reviewing the history, it is such an important log, those in person conversations need written down for the poor maintenance folks when both of you aren't available.
Do you even CI, bro? :D
I'd consider looking into Continuous Integration. Smaller commits are oftentimes safer commits.