DEV Community

Discussion on: How to code review in a start up?

Collapse
 
a_sandrina_p profile image
Sandrina Pereira

How to make time to review code

For me, code reviews are as important as writing the actual code. With your team, remember to include code reviews in your workflow, and set expectations about how long a code review might take.
I prefer to do code reviews first thing in the morning or after lunch before picking any other of my tasks. That’s what works best for me because my brain is still fresh without a previous code context to switch off from. Besides that, once I’m done with the review, I can focus on my own tasks, while the author can reevaluate the code based on the feedback.

What do you do if there isn't a reviewer available who can understand that code or programming language?

Remember to write documentation, it doesn't need to be a detailed page as MDN with full specs. I know that in a startup the time is short, so a simple, small document explaining the overall can be enough: Try to answer these questions:

  • The motivation behind,
  • Hight level approach
  • Include reference links (ex:: explaining a pattern or a known bug/workaround). When someone more familiar with the programming language looks at the code, that doc file will be gold to him/her.

How do you resolve disputes when the reviewers and the authors are the same technical level?

This one is tricky and it's where a lot can go wrong and destroy all the purpose of code reviewing. Based on my experience, the best thing you can do is to try to be flexible and put your ego aside. Learn to overcome feedback resistance and to accept trade-offs.

I've written an article about Bringing Healthy Code Review Mindset to your team some time ago. I hope it can help you and your team too.

Collapse
 
ruvans profile image
Ruth Evans

Thank you for your reply 😊 The article was really useful, especially writing a pull request template and making constructive suggestive comments instead of directive commands.